refactor(nextcloud,neon_files): Introduce PathUri for WebDAV path handling #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
changed the title
Leptopoda
requested changes
Nov 4, 2023
provokateurin
force-pushed
the
feature/nextcloud/webdav-pathuri
branch
from
dd5ed6e to
1093edc
Compare
|
I will do the testing once you are satisfied with the changes in the nextcloud package. Otherwise I might need to re-do the tedious testing if there is a behavioral change. |
provokateurin
force-pushed
the
feature/nextcloud/webdav-pathuri
branch
from
1093edc to
de8b9ed
Compare
Leptopoda
requested changes
Nov 6, 2023
provokateurin
force-pushed
the
feature/nextcloud/webdav-pathuri
branch
2 times, most recently
from
61c8c89 to
50f5553
Compare
|
I think it is much cleaner now. I reviewed the changes in neon_files and tested most of it and found no problems (but please also test). |
Leptopoda
requested changes
Nov 10, 2023
|
I didn't find any noticeable performance regressions |
provokateurin
force-pushed
the
feature/nextcloud/webdav-pathuri
branch
from
50f5553 to
c026f98
Compare
…dling Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
feature/nextcloud/webdav-pathuri
branch
from
c026f98 to
eade429
Compare
Leptopoda
approved these changes
Nov 13, 2023
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1096
I still need to test everything and I'm pretty sure I broke some stuff.