feat(dynamite): allow per spec configuration #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
force-pushed
the
feat/dynamite/per_spec_config
branch
from
5d1346d to
a758d6a
Compare
|
I think for testing this we could change some of the rules discussed in #1245 for a single (separate) spec. |
|
My long term goal was to also generate doc comments for the generated |
|
Another real world use case for this would be annotating the news, notes and uppush code as experimental because those are specs are written by hand and are not complete. |
|
I'll rebase and take a look. |
Leptopoda
force-pushed
the
feat/dynamite/per_spec_config
branch
3 times, most recently
from
2f393a7 to
6924b43
Compare
Leptopoda
force-pushed
the
feat/dynamite/per_spec_config
branch
from
6924b43 to
d031856
Compare
|
should be ready for review @provokateurin |
provokateurin
requested changes
Dec 22, 2023
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
…imental Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
feat/dynamite/per_spec_config
branch
from
d031856 to
5a5dd65
Compare
provokateurin
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we should merge this without using it.
I just wanted to get feedback and avoid letting the branch just rot on my machine