fix(dynamite): Fix nullable someOf parameters #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested changes
Dec 11, 2023
packages/dynamite/dynamite_end_to_end_test/test/parameters_test.dart
Outdated
Show resolved
Hide resolved
Leptopoda
force-pushed
the
fix/dynamite/some-of-parameters-leptopoda
branch
from
465d040 to
d819c88
Compare
provokateurin
requested changes
Dec 11, 2023
packages/dynamite/dynamite_end_to_end_test/test/parameters_test.dart
Outdated
Show resolved
Hide resolved
|
I think that it's probably easier to just call serialize (and not encode) on the typeresult and let the uri template handle the rest #1097. |
|
That sounds good yeah |
|
yet another problem related to parameter serialization: pattern checking does not work on string values. I would argue it is useless because it is an enum already, but it is a valid spec and also happens to appear in Talk. |
|
Pattern checking requires a bigger makeover. |
|
I commented on the issue, but I feel like the problem is just the parameter serialization. The value needs to be serialized before checking the pattern (would be at least one way to fix it). |
Leptopoda
force-pushed
the
fix/dynamite/some-of-parameters-leptopoda
branch
2 times, most recently
from
4bd2cb8 to
94262b5
Compare
|
Still based on #1292 |
provokateurin
approved these changes
Dec 16, 2023
Signed-off-by: jld3103 <[email protected]> Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
fix/dynamite/some-of-parameters-leptopoda
branch
from
94262b5 to
0afd4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1256