-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamite): object serialization in query parameters #1278
fix(dynamite): object serialization in query parameters #1278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think for this case alone it was nice to have the fixtures because we can be sure there were no changes. Only a small failure in the CI due to a missing serializer but I guess that can be fixed easily.
packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.json
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.json
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.json
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite/lib/src/models/openapi/parameter.dart
Outdated
Show resolved
Hide resolved
6ac38a3
to
b5456aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give it another review once rebased and the CI is fixed.
packages/dynamite/dynamite/lib/src/models/openapi/parameter.dart
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite/lib/src/models/openapi/parameter.dart
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite/lib/src/models/openapi/parameter.dart
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite/lib/src/models/openapi/parameter.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikolas Rimikis <[email protected]>
b5456aa
to
69634de
Compare
69634de
to
c29170b
Compare
packages/dynamite/dynamite/lib/src/models/openapi/parameter.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikolas Rimikis <[email protected]>
c29170b
to
0c3de09
Compare
334d403
into
feat/dynamite/always-send-default-parameters
fixes: #1097
fixes: #1172
And more :)