Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamite): object serialization in query parameters #1278

Conversation

Leptopoda
Copy link
Member

fixes: #1097
fixes: #1172
And more :)

@Leptopoda Leptopoda changed the title chore(dynamite): sort dart keywords fix(dynamite): object serialization in query parameters Dec 12, 2023
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think for this case alone it was nice to have the fixtures because we can be sure there were no changes. Only a small failure in the CI due to a missing serializer but I guess that can be fixed easily.

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give it another review once rebased and the CI is fixed.

@Leptopoda Leptopoda force-pushed the test/dynamite/parameters branch from b5456aa to 69634de Compare December 16, 2023 16:34
@Leptopoda Leptopoda changed the base branch from main to feat/dynamite/always-send-default-parameters December 16, 2023 16:35
@Leptopoda Leptopoda force-pushed the test/dynamite/parameters branch from 69634de to c29170b Compare December 16, 2023 16:48
@Leptopoda Leptopoda force-pushed the test/dynamite/parameters branch from c29170b to 0c3de09 Compare December 16, 2023 17:05
@Leptopoda Leptopoda merged commit 334d403 into feat/dynamite/always-send-default-parameters Dec 16, 2023
7 checks passed
@Leptopoda Leptopoda deleted the test/dynamite/parameters branch December 16, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused parameter maps Use UriTemplates for the Uris
2 participants