Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nextcloud_test): Remove version handling mess #1315

Merged

Conversation

provokateurin
Copy link
Member

Instead of manually keeping track of if the minor and patch versions are set we can just increment the major version and make it exclusive.

@provokateurin provokateurin force-pushed the refactor/nextcloud_test/remove-version-handling-mess branch from 4aaf38b to 18022f7 Compare December 18, 2023 17:23
@provokateurin provokateurin force-pushed the refactor/nextcloud_test/remove-version-handling-mess branch from 18022f7 to 175c1c6 Compare December 18, 2023 18:07
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup :)
I didn't test it but code looks good

@provokateurin provokateurin merged commit f67078f into main Dec 19, 2023
8 checks passed
@provokateurin provokateurin deleted the refactor/nextcloud_test/remove-version-handling-mess branch December 19, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants