-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamite): Allow int enums #1319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
packages/dynamite/dynamite/lib/src/models/type_result/enum.dart
Outdated
Show resolved
Hide resolved
I'm not sure this is the best way to do it. |
I like the idea, please go ahead |
I rebased the branch and confirmed it works with the latest specs. If you want I can push that branch if you haven't done it locally already. |
I've already rebased and done this:
I'll push it in a few minutes just want to make sure it can be easily adapted without any breaking changes. |
5ed0eb3
to
8701763
Compare
I left it on a separate commit for now so we can roll it back easier. |
I'm confused what you did in the second commit. It looks like you reverted a lot of the changes from the first commit? |
You are right. |
8701763
to
a0ad441
Compare
feat(dynamite_end_to_end_test): Add test for int enums Co-authored-by: Nikolas Rimikis <[email protected]> Signed-off-by: jld3103 <[email protected]> Signed-off-by: Nikolas Rimikis <[email protected]>
a0ad441
to
967c888
Compare
fix(dynamite): Allow int enums
fixes #1240
replaces: #1242