fix(dynamite): too long names for someOf typedefs

[Leptopoda]

No description provided.

[provokateurin]

Ugh ok no we can't do this, it's a horrible user experience. We are just working around a problem with dart doc here, we need to fix it there.

[Leptopoda]

What do you mean?

In theory we can make them visibleForTesting. Users would loose the ability to have a fromJson reviver but I doubt that this is a problem.
I also don't think that there is a way to fix this other than dartdoc generating html files with hashed names and using some sort of javaScript routing to handle the correct url client side. And I don't see them investing is such work.

[provokateurin]

Well in some places one needs to create objects, e.g. spreed signaling. Using some weird hash name is not ok there

[Leptopoda]

Well in some places one needs to create objects, e.g. spreed signaling. Using some weird hash name is not ok there

Please see the above code comment.

[provokateurin]

Just to be sure I understand the approach: The serializers and records are private and hashed, but we have proxy extensions that are human readable. There might be multiple proxy extensions pointing to the same type as they would otherwise have to have the long names we had problems. Is this correct?

One problem I still see is that someone could create a schema that has >255 characters, but we can't do much about that and it would be quite stupid anyway.

[Leptopoda]

One problem I still see is that someone could create a schema that has >255 characters, but we can't do much about that and it would be quite stupid anyway.

The good thing is that dynamite would not fail. They would just not be able to create documentation for their generated code (which is out of our responsibility).

[provokateurin]

Can you confirm that I understand this change correctly?

[provokateurin]

The commit message has a typo btw (too not to)

[Leptopoda]

Ah sorry.
Yes you understand that correctly.

[Leptopoda]

The commit message has a typo btw (too not to)

Is the rest fine? So I only need to push once more?

[provokateurin]

Please fix the typo in the commit message and pr title before merging

[Leptopoda]

Can I get a new review?
I made the serializer getter private and added one per human readable name.
As it was static this would have been one (rare) case, where a dev might have encountered the hashed name.