refactor(files_app): Restructure Blocs #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
refactor/neon_framework/options-provider
branch
from
ca142ff to
3b9f88c
Compare
provokateurin
force-pushed
the
refactor/neon_files/restructure-blocs
branch
from
dba77b8 to
6079009
Compare
Base automatically changed from
refactor/neon_framework/options-provider
to
main
July 14, 2024 17:46
provokateurin
force-pushed
the
refactor/neon_files/restructure-blocs
branch
from
6079009 to
aa72fb1
Compare
provokateurin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2215 +/- ##
=======================================
Coverage 26.29% 26.29%
=======================================
Files 362 362
Lines 136468 136470 +2
=======================================
+ Hits 35889 35891 +2
Misses 100579 100579
*This pull request uses carry forward flags. Click here to find out more. |
Leptopoda
approved these changes
Aug 16, 2024
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
refactor/neon_files/restructure-blocs
branch
from
aa72fb1 to
4080f84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the Bloc structure and improves the overall architecture of the Files app.
This is probably the right moment to add tests for everything, but that will be quite some effort.
Even without tests this can be reviewed and tested already.