Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextcloud)!: Fix deleted parent messages in spreed #2377

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

provokateurin
Copy link
Member

Fixes #2083
Upstream nextcloud/spreed#12951 (will wait for it to be merged before merging this PR)

@provokateurin provokateurin force-pushed the fix/nextcloud/deleted-parent-message branch from 7f6f665 to 204076d Compare August 13, 2024 11:12
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 59.55882% with 55 lines in your changes missing coverage. Please review.

Project coverage is 26.34%. Comparing base (955f599) to head (5f716d1).
Report is 3 commits behind head on main.

Files Patch % Lines
...nextcloud/lib/src/api/spreed/spreed.openapi.g.dart 55.40% 33 Missing ⚠️
...s/nextcloud/lib/src/api/spreed/spreed.openapi.dart 59.25% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2377      +/-   ##
==========================================
+ Coverage   26.29%   26.34%   +0.04%     
==========================================
  Files         362      362              
  Lines      136468   136589     +121     
==========================================
+ Hits        35889    35983      +94     
- Misses     100579   100606      +27     
Flag Coverage Δ *Carryforward flag
cookie_store 100.00% <ø> (ø) Carriedforward from 955f599
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 955f599
dynamite_end_to_end_test 61.84% <ø> (ø) Carriedforward from 955f599
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 955f599
neon_dashboard 96.05% <ø> (ø) Carriedforward from 955f599
neon_framework 45.83% <ø> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 955f599
neon_talk 99.45% <ø> (ø) Carriedforward from 955f599
nextcloud 22.34% <57.03%> (+0.05%) ⬆️
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 955f599
talk_app 99.36% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ramework/packages/talk_app/lib/src/blocs/room.dart 98.54% <100.00%> (+0.01%) ⬆️
...ork/packages/talk_app/lib/src/widgets/message.dart 100.00% <100.00%> (ø)
...s/nextcloud/lib/src/api/spreed/spreed.openapi.dart 33.13% <59.25%> (+0.12%) ⬆️
...nextcloud/lib/src/api/spreed/spreed.openapi.g.dart 15.19% <55.40%> (+0.19%) ⬆️

@provokateurin provokateurin marked this pull request as ready for review August 13, 2024 14:17
@provokateurin provokateurin force-pushed the fix/nextcloud/deleted-parent-message branch 2 times, most recently from 9b38f42 to 7a87d81 Compare August 15, 2024 10:20
@provokateurin provokateurin force-pushed the fix/nextcloud/deleted-parent-message branch from 7a87d81 to 5f716d1 Compare August 16, 2024 06:54
@provokateurin provokateurin merged commit 40906a1 into main Aug 16, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/nextcloud/deleted-parent-message branch August 16, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat rooms with self deleting messages fail to deserialize messages
2 participants