Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neon_framework): access account through the neon models library #2396

Merged

Conversation

Leptopoda
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.34%. Comparing base (c386495) to head (0213879).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2396   +/-   ##
=======================================
  Coverage   26.34%   26.34%           
=======================================
  Files         362      362           
  Lines      136579   136579           
=======================================
  Hits        35983    35983           
  Misses     100596   100596           
Flag Coverage Δ *Carryforward flag
cookie_store 100.00% <ø> (ø) Carriedforward from c386495
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from c386495
dynamite_end_to_end_test 61.84% <ø> (ø) Carriedforward from c386495
dynamite_runtime 85.40% <ø> (ø) Carriedforward from c386495
neon_dashboard 96.05% <ø> (ø) Carriedforward from c386495
neon_framework 45.96% <ø> (ø)
neon_http_client 93.28% <ø> (ø) Carriedforward from c386495
neon_notifications 100.00% <ø> (ø) Carriedforward from c386495
neon_talk 99.45% <ø> (ø) Carriedforward from c386495
nextcloud 22.34% <ø> (ø) Carriedforward from c386495
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from c386495
talk_app 99.36% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ackages/neon_framework/lib/src/blocs/accounts.dart 0.00% <ø> (ø)
packages/neon_framework/lib/src/blocs/apps.dart 96.34% <ø> (ø)
...ges/neon_framework/lib/src/blocs/capabilities.dart 0.00% <ø> (ø)
...n_framework/lib/src/blocs/login_check_account.dart 0.00% <ø> (ø)
...ckages/neon_framework/lib/src/blocs/next_push.dart 0.00% <ø> (ø)
...ges/neon_framework/lib/src/blocs/user_details.dart 100.00% <ø> (ø)
...ages/neon_framework/lib/src/blocs/user_status.dart 95.50% <ø> (ø)
...n_framework/lib/src/models/app_implementation.dart 0.00% <ø> (ø)
...neon_framework/lib/src/pages/account_settings.dart 0.00% <ø> (ø)
...n_framework/lib/src/pages/login_check_account.dart 0.00% <ø> (ø)
... and 8 more

@Leptopoda Leptopoda enabled auto-merge August 16, 2024 06:14
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please rebase

@Leptopoda Leptopoda force-pushed the refactor/neon_framework/import_account_through_models_library branch from 8a38a5f to d7d2db4 Compare August 16, 2024 07:12
@provokateurin provokateurin force-pushed the refactor/neon_framework/import_account_through_models_library branch from d7d2db4 to 0213879 Compare August 16, 2024 09:14
@Leptopoda Leptopoda merged commit ee355da into main Aug 16, 2024
10 checks passed
@Leptopoda Leptopoda deleted the refactor/neon_framework/import_account_through_models_library branch August 16, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants