Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextcloud)!: Make files_sharing Share label nullable #2430

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

provokateurin
Copy link
Member

Fixes #2405
Upstream PR nextcloud/server#47551

@provokateurin
Copy link
Member Author

provokateurin commented Aug 27, 2024

Ok let me actually add a test for this API.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.19%. Comparing base (953f73b) to head (fc3b443).
Report is 8 commits behind head on main.

Files Patch % Lines
...src/api/files_sharing/files_sharing.openapi.g.dart 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
+ Coverage   26.35%   27.19%   +0.83%     
==========================================
  Files         370      370              
  Lines      136662   136665       +3     
==========================================
+ Hits        36019    37163    +1144     
+ Misses     100643    99502    -1141     
Flag Coverage Δ *Carryforward flag
account_repository 99.64% <ø> (ø)
cookie_store 100.00% <ø> (ø) Carriedforward from 8e7a47d
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 8e7a47d
dynamite_end_to_end_test 61.84% <ø> (ø) Carriedforward from 8e7a47d
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 8e7a47d
neon_dashboard 96.05% <ø> (ø) Carriedforward from 8e7a47d
neon_framework 43.55% <ø> (-0.02%) ⬇️
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 8e7a47d
neon_talk 99.45% <ø> (ø) Carriedforward from 8e7a47d
nextcloud 23.24% <40.00%> (+0.95%) ⬆️
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 8e7a47d
talk_app 99.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...b/src/api/files_sharing/files_sharing.openapi.dart 26.83% <ø> (+26.11%) ⬆️
...src/api/files_sharing/files_sharing.openapi.g.dart 8.57% <40.00%> (+8.57%) ⬆️

... and 5 files with indirect coverage changes

@provokateurin provokateurin force-pushed the fix/nextcloud/files_sharing-share-label-nullable branch from d74bba7 to fc3b443 Compare August 28, 2024 06:14
@provokateurin provokateurin merged commit 52490b3 into main Aug 28, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/nextcloud/files_sharing-share-label-nullable branch August 28, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shareapi.getShares date Deserializing Error
2 participants