-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Run all Dart steps with both upgraded and downgraded dependencies #2540
Conversation
ae84095
to
ad2d4db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
==========================================
+ Coverage 28.84% 28.86% +0.01%
==========================================
Files 370 370
Lines 136490 136544 +54
==========================================
+ Hits 39376 39411 +35
- Misses 97114 97133 +19
*This pull request uses carry forward flags. Click here to find out more. |
What is the state of this PR? Other than that, great idea, and thanks for tackling this issue. |
It is basically ready, I just left the commit there to trigger the CI to show that it works.
Me neither, but it's the only way we can check that our own dependency constraints are working correctly. |
I would at least be more comfortable with the overrides if we'd use pub workspace so we only have to define them once. |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
ad2d4db
to
b4e63e6
Compare
The overrides are now applied from a patch when running with downgraded dependencies. |
b4e63e6
to
0ba2f5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. I'm way more comfortable that way.
Eh I just realized having the pubspec.lock changes in the patch as well is probably not a good idea as it is going to need manual fixing every week when renovate tries to update it. |
Just as I expected it breaks right away: https://github.com/nextcloud/neon/actions/runs/11656047519/job/32451613800?pr=2629 |
Running the tests also ensures the code actually works and it's not just throwing no linting errors.
I only added the overrides to packages with tests as there is no way to automatically verify the overrides fix the build issues otherwise.
There seem to be some runtime issues with flutter_svg and vector_graphics, but I didn't look further into those.
This is only a step in the right direction and to verify that everything is fine with downgraded dependencies we need to have tests for every package.