Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nextcloud): Add checks to ensure that all available props are parsed #2558

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 9, 2024

This is going to become a lot more useful when sabre-io/dav#1564 is merged and in a released Nextcloud version, as we are currently missing out on a lot of props when requesting all available props.

@provokateurin provokateurin force-pushed the test/nextcloud/all-props-parsed branch from 4ae9f68 to 548176b Compare October 9, 2024 14:10
@provokateurin provokateurin changed the title feat(nextcloud_test): Export NextcloudTester test(nextcloud): Add checks to ensure that all available props are parsed Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.83%. Comparing base (d672cef) to head (866e261).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2558      +/-   ##
==========================================
+ Coverage   28.79%   28.83%   +0.04%     
==========================================
  Files         370      370              
  Lines      136490   136478      -12     
==========================================
+ Hits        39296    39359      +63     
+ Misses      97194    97119      -75     
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from d672cef
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from d672cef
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from d672cef
dynamite_runtime 85.40% <ø> (ø) Carriedforward from d672cef
interceptor_http_client 97.18% <ø> (ø) Carriedforward from d672cef
neon_dashboard 96.05% <ø> (ø) Carriedforward from d672cef
neon_framework 61.00% <ø> (ø)
neon_http_client 97.50% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from d672cef
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from d672cef
nextcloud 24.32% <ø> (+0.05%) ⬆️
notifications_app 97.40% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from d672cef
talk_app 98.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@provokateurin provokateurin force-pushed the test/nextcloud/all-props-parsed branch from 548176b to 866e261 Compare October 24, 2024 12:46
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, a matcher nevertheless 😍

@provokateurin provokateurin merged commit db2f21f into main Oct 24, 2024
10 checks passed
@provokateurin provokateurin deleted the test/nextcloud/all-props-parsed branch October 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants