Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon_framework): Implement remote wipe #2664

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Nov 19, 2024

Closes #43.
Not all data is deleted yet, but that will be fixed in #2114.

Tests for the changes in AccountsBloc still have to be written, but there are no tests for it at all so far, so it is a slightly bigger task than I anticipated.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.95%. Comparing base (b389406) to head (b8eeeec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2664      +/-   ##
==========================================
+ Coverage   28.90%   28.95%   +0.04%     
==========================================
  Files         371      371              
  Lines      136623   136665      +42     
==========================================
+ Hits        39491    39569      +78     
+ Misses      97132    97096      -36     
Flag Coverage Δ *Carryforward flag
account_repository 98.57% <100.00%> (+0.10%) ⬆️
cookie_store 99.48% <ø> (ø) Carriedforward from b389406
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from b389406
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from b389406
dynamite_runtime 85.40% <ø> (ø) Carriedforward from b389406
interceptor_http_client 97.18% <ø> (ø) Carriedforward from b389406
neon_dashboard 96.05% <ø> (ø) Carriedforward from b389406
neon_framework 62.60% <100.00%> (+1.17%) ⬆️
neon_http_client 94.32% <ø> (ø) Carriedforward from b389406
neon_notifications 100.00% <ø> (ø) Carriedforward from b389406
neon_storage 94.66% <ø> (ø) Carriedforward from b389406
neon_talk 99.45% <ø> (ø) Carriedforward from b389406
nextcloud 24.33% <ø> (ø) Carriedforward from b389406
notifications_app 97.43% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from b389406
talk_app 99.01% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/neon_framework/lib/src/blocs/accounts.dart 67.08% <100.00%> (+67.08%) ⬆️
...account_repository/lib/src/account_repository.dart 100.00% <100.00%> (ø)
...epository/lib/src/utils/authentication_client.dart 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@provokateurin provokateurin force-pushed the feat/neon_framework/remote-wipe branch from 9cdbda3 to 0d8711e Compare November 19, 2024 19:22
@provokateurin provokateurin marked this pull request as ready for review November 19, 2024 19:22
@provokateurin provokateurin force-pushed the feat/neon_framework/remote-wipe branch from 0d8711e to 6482d21 Compare November 19, 2024 19:59
@provokateurin provokateurin force-pushed the feat/neon_framework/remote-wipe branch from 6482d21 to b8eeeec Compare November 19, 2024 20:03
@provokateurin
Copy link
Member Author

Note that this implementation is not per docs, as we only check if the account needs to be wiped once per app start and not for every 401/403 response we receive.
This should still be decently safe and definitely more safe than not implementing it at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement remote wipe
1 participant