-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_framework): Support custom backgrounds #943
Conversation
298abbd
to
9c80331
Compare
9c80331
to
6700edc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked much at the code but it looks fine at a first glance.
But the design is just awe full and unacceptable.
I really struggle reading any text displayed so that's also a hard no go regarding #300.
I think we should not have a background behind the main app content but i quite like how the nextcloud web interface has the image behind the drawer (with sufficient contrast!!!). I think if the option is enabled we should only show the image behind the drawer. The dashboard app could then make its scaffold background transparent. |
6ca0df8
to
f73126b
Compare
To implement this it would be great if there is a way to get cropped part of the background image. We don't want the image to repeat itself so all widgets would need to take the part of the image of their position as the background. I don't know if there is an easy way to achieve it, but using transparency like right now is definitely not good because it will break easily. |
f73126b
to
48e762c
Compare
We can still use the transparency approach but just not set it globally and only in the scaffold of the dashboard client |
The transparency approach is hard to implement and adds unnecessary code. "Punching a hole" would be way cleaner and easier to use everywhere. |
48e762c
to
f84cd25
Compare
For now I changed it so that it is a widget that can be used independently. Only used in the dashboard right now, but we can expand it later. |
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
f84cd25
to
9fd27dd
Compare
Closes #939
I'm pretty sure this whole feature but also the way I implemented it is going to be quite controversial, but please go ahead reviewing :)