-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theming): Implement Material 3 Theme #1186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
Should be #1188 |
Signed-off-by: Marcus Nilsson <[email protected]>
Fix starred items not obeying sort order
Signed-off-by: David Luhmer <[email protected]>
Signed-off-by: David Luhmer <[email protected]>
…into material-3
Signed-off-by: David Luhmer <[email protected]>
Woohoo 🥳 I didn't notice you picked up the work on this PR again @David-Development ! Thanks for finishing & merging! |
@stefan-niedermann Well.. you did most of the work so thank you for getting the ball rolling! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to align the theming between Files, Talk, Notes, Deck and News. (see also: nextcloud/notes-android#1752)
The mechanics are a bit different, because News does not support fetching the account color (yet) - however this makes it a bit easier, because we only have to define a static theme instead of calculating and applying it at runtime to each and every UI component.
Remaining issues:
dark
/light
, the statusbar andNewsReaderListFragment
have inconsistent state compared to the rest of the appI can only assume that it has to do with Dependency Injection or some other magic, but calling
Splashscreen.installSplashScreen(this)
lead to the broken behavior. Removing it solved the issue (tested on API 33 and API 28)styles.xml
andstyles-v21.xml
, because theminSdk
is already21
Export / Import OOPML
seem to be not working - I doubt that this is related to the theming changes, but it's worth a look@color/nextcloudBlue
because I don't know how they have been generatedBlack OLED Theme
still works as expected everywhereFeed dialogs are not in Material 3 theme