Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theming): Implement Material 3 Theme #1186

Merged
merged 18 commits into from
Sep 10, 2023
Merged

Conversation

stefan-niedermann
Copy link
Member

@stefan-niedermann stefan-niedermann commented Apr 11, 2023

This PR aims to align the theming between Files, Talk, Notes, Deck and News. (see also: nextcloud/notes-android#1752)

The mechanics are a bit different, because News does not support fetching the account color (yet) - however this makes it a bit easier, because we only have to define a static theme instead of calculating and applying it at runtime to each and every UI component.

_ _
light dark

Remaining issues:

  • ⚠️ When setting theme manually to dark / light, the statusbar and NewsReaderListFragment have inconsistent state compared to the rest of the app
    I can only assume that it has to do with Dependency Injection or some other magic, but calling Splashscreen.installSplashScreen(this) lead to the broken behavior. Removing it solved the issue (tested on API 33 and API 28)
  • Popup menus do have strange partial background colors at the top and bottom
  • NavigationDrawer feed items do have strange background
  • Merge styles.xml and styles-v21.xml, because the minSdk is already 21
  • Implement proper Splashscreen
  • Export / Import OOPML seem to be not working - I doubt that this is related to the theming changes, but it's worth a look
  • ⚠️ Podcast-stuff needs to be checked (I will need some help here because I don't use this)
  • ⚠️ Menu icon tints are not correct yet - needs some checking
  • Shape of the favorite action drop menu is still circular - needs adjustment for new FAB shape?
  • Favorite actions are bitmap graphics - Keeping them @color/nextcloudBlue because I don't know how they have been generated
  • Check whether Black OLED Theme still works as expected everywhere
  • Manual Login screen is not looking quite right
  • Feed dialogs are not in Material 3 theme

@stefan-niedermann stefan-niedermann marked this pull request as ready for review April 11, 2023 14:16
@Unpublished
Copy link
Collaborator

Export / Import OOPML seem to be not working - I doubt that this is related to the theming changes, but it's worth a look

Should be #1188

@David-Development David-Development merged commit f0593ed into master Sep 10, 2023
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the material-3 branch September 10, 2023 10:32
@stefan-niedermann
Copy link
Member Author

Woohoo 🥳 I didn't notice you picked up the work on this PR again @David-Development !

Thanks for finishing & merging!

@David-Development
Copy link
Member

@stefan-niedermann Well.. you did most of the work so thank you for getting the ball rolling! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants