-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
per-feed open-in settings #1266
per-feed open-in settings #1266
Conversation
Good point.. I'm not sure what I would expect as a user.. Do I want the app to open the detail view and navigate to the page automatically? (so that when I do the back navigation I get to the rss item that's stored in the app? - or do I basically want to replace it in the detail view?) So basically:
This would also make things easier I think in terms of what happens if you scroll through all unread articles in the DetailView.
Maybe just throw an exception? In that case I wouldn't mind if the app was crashing - this can't happen in real life anyways as we define which values are possible for that field. And if we ever extend it the crash will let us know |
I'm thinking that maybe we can skip the NOTE: I'd like to add that if a user clicks on an item that opens in detailed view, swiping left/right works the same as it usually does (i.e. it stays in detailed view and to open in some sort of browser, a tap on the title is required). An exception it is! |
05ca2f7
to
6281851
Compare
That sounds good to me! I agree that the Built-In Browser doesn't offer any advantage over the Chrome Custom Tabs. |
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java
Outdated
Show resolved
Hide resolved
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java
Outdated
Show resolved
Hide resolved
This adds a "Open-in settings" when long-pressing on a feed, allowing users to specify how a feed is opened. Signed-off-by: Marcus Nilsson <[email protected]>
Signed-off-by: Marcus Nilsson <[email protected]>
6281851
to
2327a4d
Compare
@mkanilsson Thank you! Looking forward to create a new release sometime this week to make all these new great features available for everyone! |
This adds a "Open-in settings" when long-pressing on a feed, allowing users to specify how a feed is opened.
This was a draft because:
Internal Browser isn't a option yet.This is marked unnecessary asChrome-Custom-Tags
is basically the same thing. (see per-feed open-in settings #1266 (comment))The option isn't persistent. Unsure why, it's stored in the database but it's always read back asThis has been fixed thanks to David! (f850ad2)null
?Unsure what a good tag here is.This has been fixed by using a RuntimeException instead.Closes #1221, #1058 and #957.
Preview
per-feed.mp4