Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per-feed open-in settings #1266

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

mkanilsson
Copy link
Contributor

@mkanilsson mkanilsson commented Sep 19, 2023

This adds a "Open-in settings" when long-pressing on a feed, allowing users to specify how a feed is opened.

This was a draft because:

  1. Internal Browser isn't a option yet. This is marked unnecessary as Chrome-Custom-Tags is basically the same thing. (see per-feed open-in settings #1266 (comment))
  2. The option isn't persistent. Unsure why, it's stored in the database but it's always read back as null? This has been fixed thanks to David! (f850ad2)
  3. Unsure what a good tag here is. This has been fixed by using a RuntimeException instead.

Closes #1221, #1058 and #957.

Preview

per-feed.mp4

@David-Development
Copy link
Member

Internal Browser isn't a option yet.

Good point.. I'm not sure what I would expect as a user.. Do I want the app to open the detail view and navigate to the page automatically? (so that when I do the back navigation I get to the rss item that's stored in the app? - or do I basically want to replace it in the detail view?)

So basically:

  • ListView user clicks on item
  • ListView -> DetailView (with RSS item) -> automatically navigates to the URL of the article
  • user performs back navigation
  • ListView -> DetailView (with RSS item)
  • user performs back navigation
  • ListView

This would also make things easier I think in terms of what happens if you scroll through all unread articles in the DetailView.


Unsure what a good tag here is.

Maybe just throw an exception? In that case I wouldn't mind if the app was crashing - this can't happen in real life anyways as we define which values are possible for that field. And if we ever extend it the crash will let us know

@mkanilsson
Copy link
Contributor Author

I'm thinking that maybe we can skip the Built-In Browser option as Chrome-Custom-Tabs offers basically the same thing with the convenience of not really leaving the app.

NOTE: I'd like to add that if a user clicks on an item that opens in detailed view, swiping left/right works the same as it usually does (i.e. it stays in detailed view and to open in some sort of browser, a tap on the title is required).


An exception it is!

@mkanilsson mkanilsson force-pushed the per-feed-open-settings branch from 05ca2f7 to 6281851 Compare September 22, 2023 13:23
@David-Development
Copy link
Member

I'm thinking that maybe we can skip the Built-In Browser option as Chrome-Custom-Tabs offers basically the same thing with the convenience of not really leaving the app.

That sounds good to me! I agree that the Built-In Browser doesn't offer any advantage over the Chrome Custom Tabs.

@mkanilsson mkanilsson marked this pull request as ready for review September 25, 2023 16:15
This adds a "Open-in settings" when long-pressing on a feed, allowing
users to specify how a feed is opened.

Signed-off-by: Marcus Nilsson <[email protected]>
@mkanilsson mkanilsson force-pushed the per-feed-open-settings branch from 6281851 to 2327a4d Compare September 26, 2023 16:37
@David-Development
Copy link
Member

@mkanilsson Thank you! Looking forward to create a new release sometime this week to make all these new great features available for everyone!

@David-Development David-Development merged commit 68c60a6 into nextcloud:master Sep 30, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-feed setting to open in detailed view or browser
2 participants