Back button preference and functionality to open sidebar #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to add a preference to restore the behaviour of the app before this commit: nextcloud@28ea07e Signed-off-by: mentalinc <[email protected]>
The back button now works as it prior to the change, there is a setting to configure if you want the back button to open the feeds list or to just exit (default) Signed-off-by: mentalinc <[email protected]>
|
Seems the Lint checks are related to code in the commit below causing errors (line 378 in SettingsFragment.java) |
|
I think you should remove the dead commented code and your log messages too :) |
|
I've left the old commented code, as it's related to the decision to investigate ALL of the onBackPressed() overrides per the discussion above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1288