Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flickering toolbar #1305

Closed
wants to merge 1 commit into from
Closed

fix flickering toolbar #1305

wants to merge 1 commit into from

Conversation

David-Development
Copy link
Member

Closes #1291

Signed-off-by: David Luhmer <[email protected]>
@stefan-niedermann
Copy link
Member

This PR sets the background color of the toolbar to the one of the content - I think it should stay in the other color, it should just not change when scrolling but always stay the default color.

@cemrich
Copy link
Contributor

cemrich commented Oct 29, 2023

The color should be "Surface", according to spec. But setting android:background="@color/surface" on the AppBarLayout does not remove the flickering. Giving the Toolbar a style of style="@style/Widget.Material3.Toolbar.Surface" does remove the flickering, but the special avatar button continues to flicker.

@David-Development
Copy link
Member Author

No matter which other color combinations I try - or even with the style="@style/Widget.Material3.Toolbar.Surface" the color that is used at runtime is different. The only color that worked was the bg_color.

@David-Development
Copy link
Member Author

Fixed in #1311

@David-Development David-Development deleted the toolbar-flickers branch November 1, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar flickers when scrolling in list
3 participants