Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloaded podcast refactoring #1364

Merged
merged 2 commits into from
Jan 17, 2024
Merged

downloaded podcast refactoring #1364

merged 2 commits into from
Jan 17, 2024

Conversation

David-Development
Copy link
Member

@David-Development David-Development commented Jan 17, 2024 •
edited
Loading

  • Add translatable strings
  • Fix bug where app crashes when the user tries to open the "Downloaded podcasts" while a download is running
  • Fix bug where "Downloaded podcasts" is not showing in case "Show only unread articles" is selected in the settings.
  • Show the number of items in the "Downloaded podcasts" section in the sidebar
  • Remove duplicate code due to merging

Follow up of #1273

@David-Development
Copy link
Member Author

@mkanilsson FYI :)

I saw that you had a few points in your MR description that were not implemented yet so I implemented them in this MR (e.g. sidebar count etc.)

@David-Development David-Development merged commit aa38bf3 into master Jan 17, 2024
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the all-downloaded-podcast-refactoring branch January 17, 2024 09:45
@mkanilsson
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@David-Development @mkanilsson