Fix inaccurate scroll bar due to lazy loading #1232 #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christine Coenen <[email protected]>
Signed-off-by: David Luhmer <[email protected]>
|
@cemrich Thank you for this great fix! It's fabulous to finally have a proper scroll state in the app. Thank you for the idea and for implementing it! 🚀 And sorry for the delay! |
Signed-off-by: David Luhmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should adjust the scrollbar to take not-yet-loaded items into account by scaling up the vertical scroll range accordingly.
I've tested this with different item layouts and it seems pretty robust - but it might break in future when lazy loaded items are prepended instead of appended to the list.