Close menu when focus leaves #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
enh/a11y-close-on-focusout
branch
from
6ecfbce to
f6db640
Compare
Pytal
requested review from
JuliaKirschenheuter,
mejo- and
nickvergessen
and removed request for
nickvergessen
|
/backport to stable25 |
nickvergessen
approved these changes
Nov 16, 2022
Comment on lines
+492
to
+496
| :deep(.button-vue) { | ||
| &:focus { | ||
| outline: 2px solid var(--color-main-text) !important; | ||
| } | ||
| } |
There was a problem hiding this comment.
Worth raising an upstream issue in the vue library? That should basically affect every place this is done?
There was a problem hiding this comment.
Based on https://github.com/nextcloud/nextcloud-vue/blob/ade7ba30f759700b3a0b28dca227009ef8157153/src/components/NcButton/NcButton.vue#L426-L429 would say this should only be done in specific cases like these where it is necessary
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When programmatically setting focus on an element i.e.
element.focus()only:focusstyles are applied but not:focus-visibleand the API which supports this is still experimental (see references below)So we add the style declaration https://github.com/nextcloud/nextcloud-vue/blob/10fbb7829803731a26ebae2f0ce0be40d26901a1/src/components/NcButton/NcButton.vue#L501 to the
:focuspseudo-class to resolve thisReferences
:focus-visiblebehavior. whatwg/html#7830