Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add app changelog parameter #1839

Closed
wants to merge 1 commit into from
Closed

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 3, 2024

Signed-off-by: Ferdinand Thiessen <[email protected]>

<template>
<NcButton v-if="canShowChangelog" class="app-changelog-button" @click="handleClick">
{{ t('notifications', 'See what\'s new for {app}', { app: name }) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't cheat this in here. It should be part of the message itself.

Also actions exist for buttons, as explained in the server pr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to make this an object (clients can fetch using OCS) so that clients do not need to move the user to a web browser. If they do not support it I expected them to use the already parsed message.

@susnux
Copy link
Contributor Author

susnux commented Mar 4, 2024

Nice! the action event system is pretty useful here - wish I found it before :/

@susnux susnux closed this Mar 4, 2024
@susnux susnux deleted the feat/app-changelog branch March 4, 2024 17:01
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants