Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop deprecated jquery functions #2134

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fix: drop deprecated jquery functions #2134

merged 2 commits into from
Dec 30, 2024

Conversation

Antreesy
Copy link
Collaborator

@Antreesy Antreesy commented Dec 30, 2024

  • Ref Migrate jQuery event usages to event-bus #1447
  • update eslint rules
  • drop usage of jquery:
    • this.$refs.icon and this.$refs.button are not existing anymore in the code, so doesn't work either way
    • $.Event('OCA.Notification.Action') is removed from server code
    • this.$parent._$el.fadeOut(OC.menuSpeed) is superseded with Vue transition-group

@Antreesy

This comment was marked as duplicate.

@nickvergessen
Copy link
Member

$.Event('OCA.Notification.Action') is removed from server code

Any app could have listened to it.
So we should add it to the upgrade docs

@Antreesy Antreesy force-pushed the fix/1447/drop-jquery branch from 802924b to ca2ed7d Compare December 30, 2024 13:11
@Antreesy
Copy link
Collaborator Author

Antreesy commented Dec 30, 2024

So we should add it to the upgrade docs

You meant here? https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_31.html

@Antreesy

This comment was marked as duplicate.

@Antreesy Antreesy force-pushed the fix/1447/drop-jquery branch from ade0c5a to ca2ed7d Compare December 30, 2024 13:35
@Antreesy
Copy link
Collaborator Author

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy merged commit 56340d4 into master Dec 30, 2024
39 checks passed
@Antreesy Antreesy deleted the fix/1447/drop-jquery branch December 30, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants