refactor(ShareApiController): Check for null and empty strings with e…

…mpty() Proactive measure to avoid warnings in higher php versions as well possible type errors Signed-off-by: fenn-cs <[email protected]>
nextcloud · Oct 25, 2024 · 2667817 · 2667817
1 parent e46f180
commit 2667817
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -660,13 +660,10 @@ public function createShare(
 		// Handle mail send
 		if (is_null($sendMail)) {
 			// Define a default behavior when sendMail is not provided
-			if ($shareType === IShare::TYPE_EMAIL && strlen($shareWith) !== 0) {
-				// For email shares, the default is to send the mail
-				$share->setMailSend(true);
-			} else {
-				// For all other share types, the default is to not send the mail
-				$share->setMailSend(false);
-			}
+			// For email shares with a valid recipient, the default is to send the mail
+			// For all other share types, the default is to not send the mail
+			$allowSendMail = ($shareType === IShare::TYPE_EMAIL && $shareWith !== null && $shareWith !== '');
+			$share->setMailSend($allowSendMail);
 		} else {
 			$share->setMailSend($sendMail === 'true');
 		}