Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Migrate away from NcAppNavigationCounter #39102

Merged
merged 1 commit into from
Jul 2, 2023
Merged

fix(settings): Migrate away from NcAppNavigationCounter #39102

merged 1 commit into from
Jul 2, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 1, 2023

Summary

  1. Replace deprecated NcAppNavigationCounter with NcCounterBubble.
  2. Also make the counter for the selected group more visible:
without highlighted with type=highlighted (current)
image image

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: settings labels Jul 1, 2023
@susnux susnux requested review from kesselb, skjnldsv, nimishavijay, a team, Fenn-CS and Pytal and removed request for a team July 1, 2023 21:18
@susnux susnux mentioned this pull request Jul 1, 2023
Open
14 tasks
@skjnldsv skjnldsv merged commit ac80328 into master Jul 2, 2023
39 checks passed
@skjnldsv skjnldsv deleted the fix/migrate-deprecated-ncappnavigationcounter branch July 2, 2023 15:30
@Pytal Pytal mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@susnux @kesselb @skjnldsv