Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflowengine): Migrate from deprecated NcMultiselect to NcSelect #39337

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 12, 2023

Summary

NcMultiselect is deprecated and will be removed with the next major release of the vue library.
This migrates the last occurence of it in server to NcSelect.

🖼️ Screenshots

before after
image image
Open menu image

Checklist

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux requested review from a team, Fenn-CS, Pytal, szaimen and artonge and removed request for a team July 12, 2023 16:07
@susnux susnux changed the title Fix/workflowengine ncmultiselect fix(workflowengine): Migrate from deprecated NcMultiselect to NcSelect Jul 12, 2023
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux merged commit 4882e5c into master Jul 12, 2023
40 checks passed
@susnux susnux deleted the fix/workflowengine-ncmultiselect branch July 12, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants