-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] Fix status check and saving of external storages #47735
Commits on Sep 5, 2024
-
fix: Remove broken jQuery tooltip
In Nextcloud 29 and later the tooltip usage threw an error that caused the UI to be unusable, so it was removed. In Nextcloud 28 there is no error, but using the jQuery tooltip call causes the tooltip to be unreadable, so it was removed as well (which makes the native tooltip to be shown instead). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e43af1d - Browse repository at this point
Copy the full SHA e43af1dView commit details -
refactor: Store result in its own variable
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fc93517 - Browse repository at this point
Copy the full SHA fc93517View commit details -
fix: Recheck userglobal storages when loaded
Userglobal storages are now automatically recheck when loaded, similarly to how it is done for global storages. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dc18849 - Browse repository at this point
Copy the full SHA dc18849View commit details -
fix: Remove status check when configuration was changed
Setting a null status was supposed to remove the status check, but nothing was changed in that case. Now the status check is properly removed, and doing that by hiding the element rather than just turning it invisible also prevents that clicking on the invisible status triggers a check, as until the new configuration is saved the check will still be performed with the old configuration, which could be misleading for the user. Additionally, an explicit width is set to the parent of the span element to prevent its width from changing when the span is shown and hidden. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9108d54 - Browse repository at this point
Copy the full SHA 9108d54View commit details -
fix: Set status tooltip to status message when saving an storage
When a storage is saved the status check can fail even if saving the storage succeeds. In those cases further details are provided in the status message of the storage, which is now set as the tooltip, similarly to how it is done when rechecking the storage. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 35f16a3 - Browse repository at this point
Copy the full SHA 35f16a3View commit details -
fix: Set status tooltip to error message on failed actions
When saving, updating and rechecking an storage fails (which is different to the soft-fail when the action itself succeeds but the status check does not) further details are provided in the error message of the response, which is now set as the tooltip. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 029626b - Browse repository at this point
Copy the full SHA 029626bView commit details -
fix: Restore default status tooltip when no status message is provided
If the status is updated but no explicit message is provided (for example, if the status check succeeded) the default tooltip (from the template) is now set to prevent a mismatch between the status and the tooltip (for example, if the configuration is fixed after a failed status check). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 65885fe - Browse repository at this point
Copy the full SHA 65885feView commit details -
fix: Add missing translation for UI string
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fa28a1d - Browse repository at this point
Copy the full SHA fa28a1dView commit details -
fix: Reset selected backend when adding a new storage
As a new storage is added by selecting a backend the selected backend needs to be reset. Otherwise it is not possible to add another storage with the same backend. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b72aebf - Browse repository at this point
Copy the full SHA b72aebfView commit details -
test: Add integration tests for saving external userglobal storages
As the external storage uses the Nextcloud server itself the number of workers of the PHP process running the Nextcloud server had to be increased. Otherwise if a request is sent for the external storage while handling a request from the integration tests a deadlock would occur. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59b62aa - Browse repository at this point
Copy the full SHA 59b62aaView commit details -
fix: Fix unmodified placeholder replacing the actual value when updating
When updating global storages and user storages a property is not updated by "StoragesService::updateStorage()" if the value matches the unmodified placeholder. However, userglobal storages are not updated through the "StoragesService"; as only the authentication mechanism is updated it is directly done with "saveBackendOptions()" in "IUserProvided" or "UserGlobalAuth". Due to this the unmodified placeholder value needs to be explicitly checked in those cases and replaced by the actual value (note that in this case it is not possible to just skip updating a specific property). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0644361 - Browse repository at this point
Copy the full SHA 0644361View commit details -
fix: Hide status tooltip in row to add a new mount point
The row to add a new mount point is cloned when a new mountpoint is added, so it is expected that it includes a status span. However, it should not be displayed in that row, only in the cloned row when its status is updated. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6d8e6b - Browse repository at this point
Copy the full SHA b6d8e6bView commit details