add activity logging for favorites in dav

[grnd-alt]

• Resolves: Missing activity for favorites via WebDAV #26393

Summary

Dav api did not log favorite added/removed events.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

Would it not be cleaner and make more sense to emit just the event and handle the activity in an event listener?

Then only one place for the activity is required and one would not mix different apps (files app activity in dav app).

[artonge]

I don't get why this is need. Isn't TagService already doing that?

server/apps/files/lib/Service/TagService.php

Lines 101 to 131 in ff9ea47

	protected function addActivity($addToFavorite, $fileId, $path) {
	$user = $this->userSession->getUser();
	if (!$user instanceof IUser) {
	return;
	}
	if ($addToFavorite) {
	$event = new NodeAddedToFavorite($user, $fileId, $path);
	} else {
	$event = new NodeRemovedFromFavorite($user, $fileId, $path);
	}
	$this->dispatcher->dispatchTyped($event);
	$event = $this->activityManager->generateEvent();
	try {
	$event->setApp('files')
	->setObject('files', $fileId, $path)
	->setType('favorite')
	->setAuthor($user->getUID())
	->setAffectedUser($user->getUID())
	->setTimestamp(time())
	->setSubject(
	$addToFavorite ? FavoriteProvider::SUBJECT_ADDED : FavoriteProvider::SUBJECT_REMOVED,
	['id' => $fileId, 'path' => $path]
	);
	$this->activityManager->publish($event);
	} catch (\InvalidArgumentException $e) {
	} catch (\BadMethodCallException $e) {
	}
	}
	}

EDIT: reading the issue

[artonge]

Maybe use those methods instead:

server/lib/private/Tags.php

Lines 481 to 497 in ff9ea47

	public function addToFavorites($objid) {
	if (!$this->userHasTag(ITags::TAG_FAVORITE, $this->user)) {
	$this->add(ITags::TAG_FAVORITE);
	}
	return $this->tagAs($objid, ITags::TAG_FAVORITE);
	}
	/**
	* Remove an object from favorites
	*
	* @param int $objid The id of the object
	* @return boolean
	*/
	public function removeFromFavorites($objid) {
	return $this->unTag($objid, ITags::TAG_FAVORITE);
	}

And then emit the event in those methods?

[artonge]

• addActivity from TagService can be copied to Tags.
• Then TagService can be deleted.
• And then

  server/apps/files/lib/Controller/ApiController.php

  Lines 126 to 127 in ff9ea47

  	$this->tagService->updateFileTags($path, $tags);
  	} catch (\OCP\Files\NotFoundException $e) {

  can be ported to use the methods mentioned above.

[artonge]

Not a good idea to break a public API by adding an argument

[susnux]

For me it feels wrong to do this here in the library instead of the files app.
I think it would be cleaner to just emit NodeAddedToFavorite in addToFavorites and the NodeRemovedFromFavorite in removeFromFavorites.

Then in the files app there could be an event listener to create the activity, so no need to wire activity management directly into the tagger.