Skip to content

Commit

Permalink
fix(a11y): provide aria-labels for screenshare buttons in every state
Browse files Browse the repository at this point in the history
Signed-off-by: Maksim Sukharev <[email protected]>
  • Loading branch information
Antreesy committed Apr 24, 2024
1 parent 7de6302 commit 27ad0ca
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/components/TopBar/TopBarMediaControls.vue
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@
<NcButton v-else-if="!isSidebar"
v-tooltip="screenSharingButtonTooltip"
type="tertiary"
:aria-label="screenSharingButtonAriaLabel"
@click.stop="toggleScreenSharingMenu">
<template #icon>
<MonitorShare :size="20" />
Expand Down Expand Up @@ -269,7 +270,7 @@ export default {

screenSharingButtonAriaLabel() {
if (this.screenSharingMenuOpen) {
return ''
return t('spreed', 'Screensharing options')
}

return this.isScreensharing
Expand Down

0 comments on commit 27ad0ca

Please sign in to comment.