-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle password policy validation #13863
Conversation
Signed-off-by: Sanskar Soni <[email protected]>
e08268b
to
0bee8e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ✅ all good regarding password policy.
Follow-up: remove the action to submit empty password as it's only possible now if you just enable the password radio button (it won't make sense to show "Conversation password has been removed" while you haven't set one yet). I will add this in further refactoring.
Thank you for you contribution 🥳 Looking forward to your next PR.
/backport to stable30 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
☑️ Resolves
🖌️ UI Checklist
@valid
,@invalid
handlers to ensure password meets policy requirements🏡 After
nextcloud-invalid-pass.mp4
🏁 Checklist