Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle password policy validation #13863

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

sanskar-soni-9
Copy link
Contributor

@sanskar-soni-9 sanskar-soni-9 commented Nov 25, 2024

☑️ Resolves

🖌️ UI Checklist

  • Added @valid, @invalid handlers to ensure password meets policy requirements
  • Moved success and error handling to store

🏡 After

nextcloud-invalid-pass.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@sanskar-soni-9 sanskar-soni-9 self-assigned this Nov 25, 2024
@sanskar-soni-9 sanskar-soni-9 force-pushed the fix/setting-invalid-password-handling branch from e08268b to 0bee8e2 Compare November 26, 2024 04:10
@sanskar-soni-9
Copy link
Contributor Author

I didn't added flex-shrink as it was making things overflow

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅ all good regarding password policy.

Follow-up: remove the action to submit empty password as it's only possible now if you just enable the password radio button (it won't make sense to show "Conversation password has been removed" while you haven't set one yet). I will add this in further refactoring.

Thank you for you contribution 🥳 Looking forward to your next PR.

@DorraJaouad DorraJaouad merged commit 5c823c1 into main Nov 28, 2024
47 checks passed
@DorraJaouad DorraJaouad deleted the fix/setting-invalid-password-handling branch November 28, 2024 12:05
@DorraJaouad
Copy link
Contributor

/backport to stable30

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a password shows success even when failing due to password policy
3 participants