-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CallView): light improvement #12300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's aligned with tests, let's go with it for now.
I'd still consider to discuss all possible variants and their outputs as follow-up (like with a table we did for scrolling)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that expected? Before it returned to the same state, you were before presentation. |
Hide an option, while there's nothing to place on grid? |
State is not restored on return from presentation
Not sure it is related, but caught an exception:
on this line spreed/src/components/CallView/CallView.vue Line 325 in 79bd33f
|
This was unrelated, but fixed as it is involved in "light improvement" :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nitpick from me, can't tell what else we could enhance atm. Behaves much better, in my opinion
3d19ea5
to
ec2b21b
Compare
ec2b21b
to
237d37b
Compare
Signed-off-by: DorraJaouad <[email protected]>
…he previous isGrid last state accurate. Signed-off-by: DorraJaouad <[email protected]>
…ences that are set during presentation Signed-off-by: DorraJaouad <[email protected]>
…or selected video. If both of happen at the same time (e.g: someone shared a screen and you are focusing of a video), closing one of them should not trigger restore to the previous state which will cancel the other. Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
☑️ Resolves
startPresentation
already handles it.🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist