Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Fix dashboard when the last message of a chat expired #12302

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(dashboard): Fix dashboard when the last message of a chat expired #12302

merged 1 commit into from
May 8, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels May 7, 2024
@nickvergessen nickvergessen added this to the 💚 Next Patch (29) milestone May 7, 2024
@nickvergessen nickvergessen requested a review from Antreesy May 7, 2024 12:57
@nickvergessen nickvergessen self-assigned this May 7, 2024
@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen nickvergessen requested a review from SystemKeeper May 7, 2024 13:27
Antreesy
Antreesy approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we could consider to use t('spreed', 'No messages') as a placeholder for such cases?

@nickvergessen
Copy link
Member Author

Something for later, would like to improve the handling to show the last mention first, instead of "You were mentioned" and then we can afterwards think about how to handle all the cases when the messages are not there anymore.

@nickvergessen nickvergessen enabled auto-merge May 8, 2024 10:04
@nickvergessen nickvergessen merged commit 5193115 into main May 8, 2024
63 checks passed
@nickvergessen nickvergessen deleted the bugfix/12282/fix-dashboard-with-expired-messages branch May 8, 2024 10:14
@backportbot backportbot bot mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Dashboard error: MessageParser::createMessage(): Argument #3 ($comment) must be of type IComment, null given
3 participants
@nickvergessen @Antreesy @danxuliu