Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): Preparse call notifications for improved performance #12303

Merged
merged 1 commit into from
May 10, 2024

Conversation

nickvergessen
Copy link
Member

Reducing the roundtrips in the notification providers by only parsing each language once

Previous PRs:

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls performance 🚀 labels May 7, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone May 7, 2024
@nickvergessen nickvergessen self-assigned this May 7, 2024
lib/Notification/Listener.php Outdated Show resolved Hide resolved
lib/Notification/Listener.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the perf/noid/improved-call-notifications branch from 3cbbcab to f742627 Compare May 10, 2024 09:25
@nickvergessen
Copy link
Member Author

/backport to stable29

Reducing the roundtrips in the notification providers by only parsing each
language once

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the perf/noid/improved-call-notifications branch from f742627 to a0f9ceb Compare May 10, 2024 15:07
@nickvergessen nickvergessen merged commit 52fbc5f into main May 10, 2024
63 checks passed
@nickvergessen nickvergessen deleted the perf/noid/improved-call-notifications branch May 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants