fix(messageStore): adjust getters and tests #12318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jest fails on "rootGetters.getToken is not a function" in further changed tests Signed-off-by: Maksim Sukharev <[email protected]>
DorraJaouad
reviewed
May 10, 2024
Antreesy
force-pushed
the
fix/noid/test-handling
branch
from
859c9ee to
407aa0a
Compare
- update messagesService, handle config objects as optional Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/test-handling
branch
from
407aa0a to
94ffda6
Compare
DorraJaouad
approved these changes
May 13, 2024
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No visual changes, but might fix some visual glitches, while server response hasn't come
🏁 Checklist