Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(polls): Import/Export pre-filled poll form to JSON 📊 #13487

Merged
merged 2 commits into from
Oct 21, 2024
Merged

feat(polls): Import/Export pre-filled poll form to JSON 📊 #13487

merged 2 commits into from
Oct 21, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 7, 2024 •
edited
Loading

☑️ Resolves

  • Ref Allow to prepare and import/export polls #13439
    • Handles import/export from/to JSON file (native browser functionality)
    • Handles only fields defined in client code
    • Skips missing and extraneous fields
    • Type/value validation? (if someone would manually create/modify JSON files for import)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 7, 2024
@Antreesy Antreesy requested a review from DorraJaouad October 7, 2024 10:49
@Antreesy Antreesy self-assigned this Oct 7, 2024
Base automatically changed from fix/noid/polls-ts to main October 7, 2024 15:22
@Antreesy Antreesy force-pushed the feat/13439/import-polls branch 2 times, most recently from d4523c1 to 2b3560c Compare October 8, 2024 12:50
@Antreesy Antreesy marked this pull request as ready for review October 8, 2024 12:53
@Antreesy Antreesy changed the title fix: store form data as a single object feat(polls): Import/Export pre-filled poll form to JSON 📊 Oct 8, 2024
@Antreesy Antreesy mentioned this pull request Oct 9, 2024
Merged
7 tasks
@Antreesy Antreesy marked this pull request as draft October 9, 2024 10:29
@Antreesy Antreesy force-pushed the feat/13439/import-polls branch from 2b3560c to 000347f Compare October 9, 2024 13:16
@Antreesy Antreesy mentioned this pull request Oct 10, 2024
Merged
12 tasks
@Antreesy Antreesy force-pushed the feat/13439/import-polls branch 2 times, most recently from e920cff to cc1ad1b Compare October 18, 2024 16:59
@Antreesy Antreesy requested a review from DorraJaouad October 18, 2024 17:00
@Antreesy Antreesy marked this pull request as ready for review October 18, 2024 17:01
DorraJaouad
DorraJaouad approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected 👍🏻

src/components/PollViewer/PollViewer.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/13439/import-polls branch from cc1ad1b to fe543af Compare October 21, 2024 10:58
DorraJaouad
DorraJaouad approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code 👍🏻

@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit ed6ad0d into main Oct 21, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/13439/import-polls branch October 21, 2024 13:33
@backportbot backportbot bot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: polls 📊
Projects
💬 Talk team
Status: ☑️ Done
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad