Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(polls): Allow moderators to draft polls #13506

Merged
merged 5 commits into from
Oct 11, 2024
Merged

feat(polls): Allow moderators to draft polls #13506

merged 5 commits into from
Oct 11, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 10, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Allow posting drafts
  • Allow deleting drafts
  • Allow retrieving all drafts
  • Integration tests

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Oct 10, 2024
@nickvergessen nickvergessen self-assigned this Oct 10, 2024
@nickvergessen nickvergessen marked this pull request as draft October 10, 2024 09:04
@nickvergessen nickvergessen force-pushed the feat/13439/drafts-for-polls branch from d16811c to 3225a1c Compare October 10, 2024 10:20
@nickvergessen nickvergessen marked this pull request as ready for review October 10, 2024 12:07
Antreesy
Antreesy approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoints are tested against frontend, works as expected

lib/Controller/PollController.php Show resolved Hide resolved
@Antreesy Antreesy mentioned this pull request Oct 10, 2024
Merged
12 tasks
@nickvergessen nickvergessen force-pushed the feat/13439/drafts-for-polls branch from d06b955 to 3a8660f Compare October 11, 2024 12:03
Antreesy
Antreesy approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

tests/integration/features/chat-3/poll.feature Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feat/13439/drafts-for-polls branch from 3a8660f to 7c427d2 Compare October 11, 2024 13:41
@nickvergessen nickvergessen merged commit 58c1611 into main Oct 11, 2024
69 checks passed
@nickvergessen nickvergessen deleted the feat/13439/drafts-for-polls branch October 11, 2024 13:53
@nickvergessen
Copy link
Member Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: polls 📊
Projects
💬 Talk team
Status: ☑️ Done
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy