Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: draft polls management 📊 #13518

Merged
merged 4 commits into from
Oct 18, 2024
Merged

feat: draft polls management 📊 #13518

merged 4 commits into from
Oct 18, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 11, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Creation Open poll
image image
Closed poll Shared Items
image image
Filled, from Poll Editor Empty, from Shared items
image image
Opened from DraftHandler ('Back' arrow) -
image -

🚧 Tasks

  • Dialog + Placement
    • Empty View
  • Draft deletion
  • Follow-ups:
    • Poll editor to 'normal' width
      • Make fields clearable
      • add EmojiPicker
    • Unify editor + drafts into a single dialog to avoid re-rendering

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 11, 2024
@Antreesy Antreesy self-assigned this Oct 11, 2024
@Antreesy Antreesy mentioned this pull request Oct 11, 2024
Merged
12 tasks
@Antreesy Antreesy force-pushed the feat/13439/drafts-for-polls-frontend branch from 06413e0 to 9c30404 Compare October 14, 2024 07:40
Base automatically changed from feat/13439/drafts-for-polls-frontend to main October 14, 2024 10:11
An error occurred while trying to automatically change base from feat/13439/drafts-for-polls-frontend to main October 14, 2024 10:11
@Antreesy Antreesy force-pushed the feat/13439/drafts-for-polls-frontend-2 branch from 5ad83f9 to 529d2de Compare October 14, 2024 13:42
@Antreesy Antreesy requested a review from DorraJaouad October 14, 2024 13:46
@Antreesy Antreesy force-pushed the feat/13439/drafts-for-polls-frontend-2 branch from 529d2de to c22c94f Compare October 14, 2024 18:45
@Antreesy Antreesy marked this pull request as ready for review October 14, 2024 18:45
DorraJaouad
DorraJaouad reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works well

src/components/NewMessage/NewMessagePollEditor.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessagePollEditor.vue Show resolved Hide resolved
src/components/NewMessage/NewMessagePollEditor.vue Show resolved Hide resolved
src/components/PollViewer/PollDraftHandler.vue Outdated Show resolved Hide resolved
src/components/PollViewer/PollDraftHandler.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessagePollEditor.vue Outdated Show resolved Hide resolved
src/components/PollViewer/PollDraftHandler.vue Show resolved Hide resolved
src/components/NewMessage/NewMessagePollEditor.vue Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/NewMessage/NewMessagePollEditor.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/13439/drafts-for-polls-frontend-2 branch from 2dc84b2 to 5e43f15 Compare October 18, 2024 10:06
@Antreesy
feat: save poll drafts from filled forms, created and closed polls
d9e926c 
- use isFilled as simple validator

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
feat: browse poll drafts from poll editor and shared items
5a07116 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
feat: create new poll from drafts
d07fc91 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
feat: delete poll drafts
72b5efb 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the feat/13439/drafts-for-polls-frontend-2 branch from 5e43f15 to 72b5efb Compare October 18, 2024 14:34
@Antreesy
Copy link
Contributor Author

/backport to stable30

DorraJaouad
DorraJaouad approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🦅

@Antreesy Antreesy merged commit 1ae5bfd into main Oct 18, 2024
47 checks passed
@Antreesy Antreesy deleted the feat/13439/drafts-for-polls-frontend-2 branch October 18, 2024 15:19
@backportbot backportbot bot mentioned this pull request Oct 18, 2024
Merged
@Antreesy Antreesy mentioned this pull request Oct 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client feature: polls 📊
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @marcoambrosini @DorraJaouad