Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PublicShareSidebar for Nextcloud 31 #13628

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: PublicShareSidebar for Nextcloud 31 #13628

wants to merge 3 commits into from
+56 −164

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

⚠️ Not sure about the new way of getting shareToken, but previous method is no longer available

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Oct 24, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 24, 2024
@Antreesy Antreesy self-assigned this Oct 24, 2024
@nickvergessen
Copy link
Member

Failing sharing tests are unrelated and fixed by #13632

@Antreesy
fix: refactor PublicShareSidebarTrigger
e40bcaf 
- replace NcButton with NcHeaderButton
- move to script setup TS
- adjust mountpoint to .header-end

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: refactor PublicShareSidebar
0881177 
- wrap mounting in function
- adjust shareToken receiving to server API
- adjust mountpoint to #content-vue

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: cleanup styles
1d675ee 
- remove publicshare.css as redundant
- keep footer in place, adjust width if talk sidebar is open

Signed-off-by: Maksim Sukharev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ShGKme ShGKme Awaiting requested review from ShGKme

@danxuliu danxuliu Awaiting requested review from danxuliu

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Talk sidebar not shown for public shares in Nextcloud 31
2 participants
@Antreesy @nickvergessen