Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(capabilities): add sip-dialin-info capability #13659

Closed
wants to merge 4 commits into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 29, 2024

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Add sip-dialin-info available only in the initial state to capabilities for clients
  • Use capabilities instead of initial state on frontend
  • Remove unneeded initial state

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@ShGKme ShGKme added 2. developing feature: api 🛠️ OCS API for conversations, chats and participants feature: SFU & SIP ☎️ labels Oct 29, 2024
@ShGKme ShGKme added this to the 🖤 Next Major (31) milestone Oct 29, 2024
@ShGKme ShGKme self-assigned this Oct 29, 2024
@nickvergessen
Copy link
Member

I'm not sure why we went with initial state back then.
I think we should have this on a dedicated endpoint.

It actually is already. Could we then simply migrate the usages over? The sipDialinInfo is part of the signaling settings returned on GET /api/{apiVersion}/signaling/settings

* sipDialinInfo: string,

@nickvergessen
Copy link
Member

nickvergessen commented Nov 29, 2024

@nickvergessen nickvergessen deleted the feat/sip-dialin-info-capability branch November 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing feature: api 🛠️ OCS API for conversations, chats and participants feature: SFU & SIP ☎️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants