Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out of office caption #13920

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Dec 2, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy December 2, 2024 11:34
@DorraJaouad DorraJaouad self-assigned this Dec 2, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@nickvergessen nickvergessen merged commit 099d03a into main Dec 2, 2024
47 checks passed
@DorraJaouad
Copy link
Contributor Author

/backport to stable30

@nickvergessen nickvergessen deleted the fix/13907/out-of-office-caption branch December 2, 2024 11:41
Copy link

backportbot bot commented Dec 2, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/13920/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1048f530

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/13920/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/13920/stable30."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOO message doesn't handle " in user displayname
3 participants