-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AdminSettings): test Websocket connection #13973
base: main
Are you sure you want to change the base?
Conversation
60416d3
to
42c707f
Compare
I'm lacking knowledge on how else this connection could fail (and how to reproduce it), so wouldn't mind a second opinion here |
Another thing you could test here is sending a |
Regarding testing: this will also fail if the signaling server url is incorrect and the request can't be upgraded to a WebSocket. This can be seen in the response (could be 404 for unknown urls or something like 400 for valid urls that don't support WebSocket), but I'm not sure if you get all the details from the JavaScript API. |
As I had a HPB setup support request from a customer yesterday where the backend url was a problem, this would be really great to test from the admin settings. Maybe you could also show the backend url ithat Talk will send to the signaling server in the UI so the user can compare with the configuration of the signaling server (see https://github.com/strukturag/nextcloud-spreed-signaling/blob/0a04ea290969cfe1ebc3ef3aaeeae1bdc49ea552/server.conf.in#L125-L126).
|
Will take a look UPD: Assume that |
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
42c707f
to
4ddb6a4
Compare
☑️ Resolves
Allows to test websocket connection with HPB in Admin settings (before users will face it in Talk interface): client attempts to establish new websocket, then:
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist