Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NewMessage): prevent placeholder content overflow #14059

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix(NewMessage): prevent placeholder content overflow #14059

merged 1 commit into from
Dec 30, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Follow-up to library bump (8.22)
  • border-radius is set to upstream component (8px);
  • max-height is set to upstream component (5.5 * 34px ~ 180px);
  • padding is set with CSS variables;

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 30, 2024
@Antreesy Antreesy requested a review from ShGKme December 30, 2024 12:18
@Antreesy Antreesy self-assigned this Dec 30, 2024
@Antreesy Antreesy mentioned this pull request Dec 30, 2024
Open
66 tasks
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit 8876415 into main Dec 30, 2024
50 checks passed
@Antreesy Antreesy deleted the fix/noid/rich-content-overflow branch December 30, 2024 12:56
@backportbot backportbot bot mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @ShGKme