Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(moderator): Allow promoting self-joined participants to moderators #14079

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(moderator): Allow promoting self-joined participants to moderators #14079

merged 1 commit into from
Jan 8, 2025
+21 −2

Conversation

nickvergessen
Copy link
Member

🛠️ API Checklist

  • Create a public conversation
  • Join as a second user
  • With the first user try to promote the second one

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Jan 8, 2025
@nickvergessen nickvergessen self-assigned this Jan 8, 2025
@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen
Copy link
Member Author

/backport to stable28

Antreesy
Antreesy approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickvergessen nickvergessen merged commit 41f8dfd into main Jan 8, 2025
76 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/allow-to-promote-self-joined-users branch January 8, 2025 14:40
This was referenced Jan 8, 2025
Merged
Merged
Merged
@SystemKeeper SystemKeeper mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @SystemKeeper @Antreesy