-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add description field for views #1664
Conversation
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
1bd8b9b
to
5ea54e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I tested it out and it works for me.
Was there a reason why we didn't add a description to Views just like we did to normal tables? I can't remember if we discussed it or not. @blizzz
{{ t('tables', 'Description') }} | ||
</div> | ||
<div class="col-4"> | ||
<TableDescription :description.sync="description" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we had a reason for not having a description in views, changes look good to me.
In future edits, we could consider renaming TableDescription
component to a generic name Description
A bit off topic, but I'm also wondering if we could have just used a rich text description like this for Applications too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can rename it in the upcoming versions
I am not aware. I believe we just inherited it like this. Do we show descriptions in the context view? Or only the context's own one? |
Addresses #1194 |
Thank you @Koc 🙇 |
There is a column
description
in database and BE part is ready to store it. But for some reason its not used on FE side.🔍 Preview