Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add description field for views #1664

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Feb 28, 2025

There is a column description in database and BE part is ready to store it. But for some reason its not used on FE side.

🔍 Preview

image

image

@Koc Koc requested review from enjeck and blizzz as code owners February 28, 2025 00:26
@Koc Koc force-pushed the feature/add-description-for-views branch from 1bd8b9b to 5ea54e9 Compare February 28, 2025 00:48
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I tested it out and it works for me.

Was there a reason why we didn't add a description to Views just like we did to normal tables? I can't remember if we discussed it or not. @blizzz

{{ t('tables', 'Description') }}
</div>
<div class="col-4">
<TableDescription :description.sync="description" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we had a reason for not having a description in views, changes look good to me.

In future edits, we could consider renaming TableDescription component to a generic name Description

A bit off topic, but I'm also wondering if we could have just used a rich text description like this for Applications too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can rename it in the upcoming versions

@blizzz
Copy link
Member

blizzz commented Mar 10, 2025

Thanks. I tested it out and it works for me.

Was there a reason why we didn't add a description to Views just like we did to normal tables? I can't remember if we discussed it or not. @blizzz

I am not aware. I believe we just inherited it like this.

Do we show descriptions in the context view? Or only the context's own one?

@blizzz
Copy link
Member

blizzz commented Mar 10, 2025

Addresses #1194

@blizzz blizzz linked an issue Mar 10, 2025 that may be closed by this pull request
@blizzz blizzz requested a review from a team March 10, 2025 19:09
@blizzz blizzz merged commit 8c20d5f into main Mar 20, 2025
49 checks passed
@blizzz blizzz deleted the feature/add-description-for-views branch March 20, 2025 17:13
@blizzz
Copy link
Member

blizzz commented Mar 20, 2025

Thank you @Koc 🙇

@juliusknorr juliusknorr added the enhancement New feature or request label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add view decriptions
5 participants