fix(DB): reduce number of SQL queries to get shares #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Apr 16, 2025
| ) | ||
| ) | ||
| ) | ||
| ->andWhere($qb->expr()->eq('node_type', $qb->createNamedParameter($nodeType, IQueryBuilder::PARAM_STR))) |
There was a problem hiding this comment.
While at it please add an index as well for this one if it is worth, seems we don't have any on oc_tables_share yet 🙈
There was a problem hiding this comment.
That's the plan. We get a anonymized production dump, when experimenting with indexes and dev data, we always ended up with a full table scan either way.
2 tasks
Signed-off-by: Arthur Schiwon <[email protected]>
enjeck
force-pushed
the
fix/noid/share-permissions-optimization
branch
from
dbba27c to
e806ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.