refactor: turn columnSettings data from loose array to value object #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AIlkiv if you don't mind, I'll fancy your opinion as well. |
blizzz
force-pushed
the
feat/1154/view-column-info-value-obj
branch
from
aee8e44 to
2031718
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
feat/1154/view-column-info-value-obj
branch
from
2031718 to
870def3
Compare
blizzz
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to make it easier to add properties like read-only or mandatory to user columns. Having the structure in a separate class makes it easier to organize it (no loose array structure flying around), to extend it and also to enforce the structure.
I thought creating a PR for the read-only feature first, but I think it is already a good size for a PR on its own.