Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert log class to kotlin #4574

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Convert log class to kotlin #4574

merged 2 commits into from
Jan 3, 2025

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Jan 3, 2025

minor followup for #4536

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi added 2 commits January 3, 2025 12:44
Signed-off-by: Marcel Hibbe <[email protected]>
@JvmStatic is necessary to keep the static behavior of the method calls

Signed-off-by: Marcel Hibbe <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 3, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4574-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Codacy

Lint

TypemasterPR
Warnings158158
Errors7171

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@mahibi mahibi merged commit 22efcd7 into master Jan 3, 2025
18 checks passed
@mahibi mahibi deleted the convertLogClassToKotlin branch January 3, 2025 12:14
@mahibi
Copy link
Collaborator Author

mahibi commented Jan 3, 2025

/backport to stable-20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant