Skip to content

update WebRtc lib to 135.7049.0 (fails) #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

update WebRtc lib to 135.7049.0 (fails) #4852

wants to merge 1 commit into from

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Apr 9, 2025

🚧 TODO

With the new webrtc lib the build fails with error below.
It's not related to proguard.

2025-04-09 10:05:16.525 17051-17051 org.webrtc.Logging      com.nextcloud.talk2                  I  NativeLibrary: Loading native library: jingle_peerconnection_so
2025-04-09 10:05:16.526 17051-17051 org.webrtc.Logging      com.nextcloud.talk2                  I  NativeLibrary: Loading library: jingle_peerconnection_so
2025-04-09 10:05:16.530 17051-17051 System.err              com.nextcloud.talk2                  W  java.lang.ClassNotFoundException: Didn't find class "org.jni_zero.JniInit" on path: DexPathList[[zip file "/data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk"],nativeLibraryDirectories=[/data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/lib/arm64, /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!/lib/arm64-v8a, /system/lib64, /system_ext/lib64]]
2025-04-09 10:05:16.530 17051-17051 System.err              com.nextcloud.talk2                  W  	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.Runtime.nativeLoad(Native Method)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.Runtime.nativeLoad(Runtime.java:1126)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.Runtime.loadLibrary0(Runtime.java:1080)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.Runtime.loadLibrary0(Runtime.java:1003)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.System.loadLibrary(System.java:1661)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at org.webrtc.NativeLibrary$DefaultLoader.load(NativeLibrary.java:20)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at org.webrtc.NativeLibrary.initialize(NativeLibrary.java:41)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at org.webrtc.PeerConnectionFactory.initialize(PeerConnectionFactory.java:297)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at com.nextcloud.talk.application.NextcloudTalkApplication.initializeWebRtc(NextcloudTalkApplication.kt:119)
2025-04-09 10:05:16.531 17051-17051 System.err              com.nextcloud.talk2                  W  	at com.nextcloud.talk.application.NextcloudTalkApplication.onCreate(NextcloudTalkApplication.kt:141)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1316)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7208)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2360)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.os.Handler.dispatchMessage(Handler.java:111)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.os.Looper.loopOnce(Looper.java:242)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.os.Looper.loop(Looper.java:362)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at android.app.ActivityThread.main(ActivityThread.java:8448)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at java.lang.reflect.Method.invoke(Native Method)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
2025-04-09 10:05:16.532 17051-17051 System.err              com.nextcloud.talk2                  W  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:992)
2025-04-09 10:05:16.532 17051-17051 jni_zero                com.nextcloud.talk2                  W  jni_zero.cc:39 Failed to find class org/jni_zero/JniInit
2025-04-09 10:05:16.533 17051-17051 libc                    com.nextcloud.talk2                  A  Fatal signal 5 (SIGTRAP), code 1 (TRAP_BRKPT), fault addr 0x7720a730d8 in tid 17051 (nextcloud.talk2), pid 17051 (nextcloud.talk2)
2025-04-09 10:05:16.578 17051-17110 Compatibil...geReporter com.nextcloud.talk2                  D  Compat change id reported: 160794467; UID 10370; state: ENABLED
2025-04-09 10:05:16.649 17051-17108 TrafficStats            com.nextcloud.talk2                  D  tagSocket(114) with statsTag=0x8001, statsUid=-1
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A  Cmdline: com.nextcloud.talk2
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A  pid: 17051, tid: 17051, name: nextcloud.talk2  >>> com.nextcloud.talk2 <<<
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #00 pc 00000000004730d8  /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!libjingle_peerconnection_so.so (offset 0x1eec000) (BuildId: ce64e1b8493638bb)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #01 pc 0000000000472cb4  /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!libjingle_peerconnection_so.so (offset 0x1eec000) (BuildId: ce64e1b8493638bb)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #02 pc 0000000000472974  /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!libjingle_peerconnection_so.so (offset 0x1eec000) (BuildId: ce64e1b8493638bb)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #03 pc 00000000004777e0  /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!libjingle_peerconnection_so.so (offset 0x1eec000) (BuildId: ce64e1b8493638bb)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #04 pc 0000000000278ad0  /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!libjingle_peerconnection_so.so (offset 0x1eec000) (JNI_OnLoad+64) (BuildId: ce64e1b8493638bb)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #32 pc 00000000001be020  [anon:dalvik-classes21.dex extracted in memory from /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!classes21.dex] (org.webrtc.NativeLibrary$DefaultLoader.load+0)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #37 pc 00000000001be110  [anon:dalvik-classes21.dex extracted in memory from /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!classes21.dex] (org.webrtc.NativeLibrary.initialize+0)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #42 pc 00000000001c2814  [anon:dalvik-classes21.dex extracted in memory from /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!classes21.dex] (org.webrtc.PeerConnectionFactory.initialize+0)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #47 pc 0000000000015a58  [anon:dalvik-classes13.dex extracted in memory from /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!classes13.dex] (com.nextcloud.talk.application.NextcloudTalkApplication.initializeWebRtc+0)
2025-04-09 10:05:16.841 17116-17116 DEBUG                   pid-17116                            A        #52 pc 0000000000015aac  [anon:dalvik-classes13.dex extracted in memory from /data/app/~~mpSOgy4VZq3snh0SSLO9Vw==/com.nextcloud.talk2-7EFJS4Ckt52ZcRl1Cf2h3w==/base.apk!classes13.dex] (com.nextcloud.talk.application.NextcloudTalkApplication.onCreate+0)

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Apr 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Codacy

Lint

TypemasterPR
Warnings9897
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222118
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310206

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4852-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

This was referenced Apr 9, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mahibi mahibi

Labels
don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mahibi